Dan Hecht has posted comments on this change. Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3637/2/be/src/exec/kudu-scan-node.cc File be/src/exec/kudu-scan-node.cc: PS2, Line 456: TODO: Refactor so the 'check if done' state change is atomic. > Sure. I think abstraction was the wrong way to phrase it, rather just that Rather than factoring out the "done" code, an alternative that might work is to factor the scanning code itself into subroutines. Not sure which would come out nicer. -- To view, visit http://gerrit.cloudera.org:8080/3637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22adf2109b43b1b37d9a597de85e063431dff155 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
