Hello David Ribeiro Alves,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3637
to look at the new patch set (#3).
Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads
......................................................................
IMPALA-3857: KuduScanNode race on returning "optional" threads
The KuduScanNode could return all active scanner threads
when there were no more "optional" tokens available. In this
case, any remaining scan ranges wouldn't be picked up and
the query would produce incorrect results. Eventually we
will revisit our thread management, but the fix for now is to
make sure at least one scanner threads remains. This is
essentially the same behavior as the HDFS scan node (though
there is a lot more complexity there).
This was tested by running the tpch workload repeatedly
under load. That work to incorporate tpch data loading for
Kudu is actively being worked on, so this was tested manually.
Change-Id: I22adf2109b43b1b37d9a597de85e063431dff155
---
M be/src/exec/kudu-scan-node.cc
M be/src/exec/kudu-scan-node.h
2 files changed, 112 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/37/3637/3
--
To view, visit http://gerrit.cloudera.org:8080/3637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22adf2109b43b1b37d9a597de85e063431dff155
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
