Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads ......................................................................
Patch Set 3: Ok, so I tried to refactor the exit/cleanup logic to be a bit more sane. The extra methods are annoying but I think it makes it clear what's going on. I was looking at the unit test code to see if I could make improvements there, but that'll take a while longer and in the meantime I actually get good coverage running the tpch tests (from Dimitris, currently in CR) and verified all the code paths are exercised with my additional logging. -- To view, visit http://gerrit.cloudera.org:8080/3637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22adf2109b43b1b37d9a597de85e063431dff155 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: No
