Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ......................................................................
Patch Set 32: (7 comments) http://gerrit.cloudera.org:8080/#/c/3081/32/be/src/benchmarks/bswap-benchmark.cc File be/src/benchmarks/bswap-benchmark.cc: Line 46: /// OldImpala 1.224e+06 1X > Hi Jim. I have rebased this patch. And there arises another issue: I use ma Templates declared in .h files must be defined in .h files: http://stackoverflow.com/questions/495021/why-can-templates-only-be-implemented-in-the-header-file Line 91: const int DataLen = 1000000; our code style uses lower_case_with_underscores for local variables: https://google.github.io/styleguide/cppguide.html Line 92: uint8_t* SourceData = new uint8_t[DataLen]; > Hi Jim. The std::vector is not applicable here since the input data should vector<uint8_t> something; &something[0]; Line 145: data.inbuffer = new uint8_t[datalen]; > Hi Jim. The std::vector is not applicable here since the input data should See above. http://gerrit.cloudera.org:8080/#/c/3081/33/be/src/benchmarks/bswap-benchmark.cc File be/src/benchmarks/bswap-benchmark.cc: Line 47: /// FastScala 1.286e+06 1.051X This is gone, please remove it from benchmark. Line 68: return; This is a test, not a benchmark, so belongs in test file. http://gerrit.cloudera.org:8080/#/c/3081/32/be/src/util/bit-util.h File be/src/util/bit-util.h: Line 250: void ByteSwapScalarLoop(void* dst, const void* src, int len); > Hi Jim. These declarations will be referred by bswap-benchmark.cc, bit-util Not all of them, though, right? Just some of them? -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 32 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
