Youwei Wang has posted comments on this change.

Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or 
AVX2.
......................................................................


Patch Set 32:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3081/32/be/src/benchmarks/bswap-benchmark.cc
File be/src/benchmarks/bswap-benchmark.cc:

Line 46: ///                      OldImpala           1.224e+06                 
 1X
> Done
Hi Jim. I have rerun this benchmark using the latest benchmarking output 
system. The result is copied as following:

I0722 22:22:56.790194 28889 bswap-benchmark.cc:117] Machine Info: Intel(R) 
Core(TM) i5-4460  CPU @ 3.20GHz
ByteSwap benchmark:        Function  iters/ms   10%ile   50%ile   90%ile     
10%ile     50%ile     90%ile
                                                                         
(relative) (relative) (relative)
---------------------------------------------------------------------------------------------------------
                         FastScalar                600      639      680        
 1X         1X         1X
                              SSSE3           5.75e+03 5.85e+03 5.88e+03      
9.58X      9.15X      8.64X
                               AVX2           1.38e+04 1.76e+04 1.77e+04        
23X      27.6X      26.1X
                               SIMD           1.75e+04 1.77e+04 1.78e+04      
29.2X      27.8X      26.2X

For this new result is a little wide here, (more than 90 characters), I have 
done some little modification to make sure the result confirms to the format 
requirement of Impala code.


-- 
To view, visit http://gerrit.cloudera.org:8080/3081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1
Gerrit-PatchSet: 32
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Youwei Wang <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Youwei Wang <[email protected]>
Gerrit-HasComments: Yes

Reply via email to