Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ......................................................................
Patch Set 30: (5 comments) http://gerrit.cloudera.org:8080/#/c/3081/30/be/src/util/bit-util-test.cc File be/src/util/bit-util-test.cc: Line 127: // CpuFlag parameter indicates SIMD routine to be tested: CpuFlag can also be 0. Please indicate that in the comment http://gerrit.cloudera.org:8080/#/c/3081/30/be/src/util/bit-util.cc File be/src/util/bit-util.cc: This was inline probably for performance reasons. Don't un-inline, please. http://gerrit.cloudera.org:8080/#/c/3081/30/be/src/util/bit-util.h File be/src/util/bit-util.h: Line 32: typedef void (*SimdFuncPointer)(uint8_t* dst, const uint8_t* src); I think I asked you to put this in a details namespace inside Impala. Line 33: typedef __uint128_t uint128_t; Did you add this, or is this from rebasing? Line 251: void ByteSwapSSE_Unit(uint8_t* dst, const uint8_t* src); Please put these in a details namespace. -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 30 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
