Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3873: Add QueryStateAccessor ......................................................................
Patch Set 1: (2 comments) This change makes the code a lot cleaner and easy to understand. Thanks for doing this. http://gerrit.cloudera.org:8080/#/c/3678/1/be/src/service/impala-server.h File be/src/service/impala-server.h: PS1, Line 486: /// The number of scan ranges that have completed : int64_t num_complete_scan_ranges; : : /// The total number of scan ranges. : int64_t total_scan_ranges; These were previously misnomers right? Maybe add that in the commit message. http://gerrit.cloudera.org:8080/#/c/3678/1/be/src/service/query-state-accessor.cc File be/src/service/query-state-accessor.cc: PS1, Line 56: Copied by value Why go with copy by value? It seems like there's a lot of stuff to copy in a QueryStateRecord. -- To view, visit http://gerrit.cloudera.org:8080/3678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3dae66a81988c99cde1516ff511186e17dd8c0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
