Tim Armstrong has posted comments on this change. Change subject: IMPALA-3873: Add QueryStateAccessor ......................................................................
Patch Set 1: (5 comments) Design makes sense to me, only had some minor comments. http://gerrit.cloudera.org:8080/#/c/3678/1/be/src/service/query-state-accessor.cc File be/src/service/query-state-accessor.cc: Line 27: virtual const std::string profile_str() const { return record_.profile_str; } It's a little unfortunate that we have to copy these profiles strings again when returning them. Probably not worth worrying about though. PS1, Line 29: TUniqueId Why return by ref? This should be cheap to copy. PS1, Line 56: Copied by value > the answer is the second part of this sentence: It seems possibly better to use shared_ptr for QueryStateRecords to avoid the copy, since QueryStateRecord is an immutable struct (if I understand correctly) Not sure if this is worth optimising though to be honest. http://gerrit.cloudera.org:8080/#/c/3678/1/be/src/service/query-state-accessor.h File be/src/service/query-state-accessor.h: Line 30: /// safe. We should document that values that are returned by reference are only guaranteed to be valid as long as the QueryStateAccessor is valid. http://gerrit.cloudera.org:8080/#/c/3678/1/www/query_detail_tabs.tmpl File www/query_detail_tabs.tmpl: Line 10: ? -- To view, visit http://gerrit.cloudera.org:8080/3678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3dae66a81988c99cde1516ff511186e17dd8c0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
