Henry Robinson has posted comments on this change. Change subject: IMPALA-3873: Add QueryStateAccessor ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3678/1/be/src/service/query-state-accessor.cc File be/src/service/query-state-accessor.cc: PS1, Line 56: Copied by value > Why go with copy by value? It seems like there's a lot of stuff to copy in the answer is the second part of this sentence: "to ensure that its contents are accessible for the lifetime of this accessor". There are other options, but none seem particularly attractive. -- To view, visit http://gerrit.cloudera.org:8080/3678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3dae66a81988c99cde1516ff511186e17dd8c0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
