Alex Behm has posted comments on this change. Change subject: IMPALA-3820: Handle linkage errors while loading Java UDFs in Catalog ......................................................................
Patch Set 1: (2 comments) Given the severity of the potential consequences (catalog fails to start), I think we should add a simple test, if feasible. http://gerrit.cloudera.org:8080/#/c/3567/1//COMMIT_MSG Commit Message: Line 19: Then I corrupted the jar by removing some classes classes from it. double "classes" http://gerrit.cloudera.org:8080/#/c/3567/1/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java: Line 468: } catch (LinkageError e) { let's move this below the "catch (Exception e)" below, otherwise that block will catch the ImpalaRuntimeException and wrap it into another ImpalaRuntimeException -- To view, visit http://gerrit.cloudera.org:8080/3567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1109614f1617caa9bb27e8c151e902aae71a6b41 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
