Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3820: Handle linkage errors while loading Java UDFs in Catalog ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/3567/4/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: Line 157: """ This tests if Catalog server can gracefully handle Java UDFs > prefix with "IMPALA-3820: " Done http://gerrit.cloudera.org:8080/#/c/3567/4/tests/test-hive-udfs/pom.xml File tests/test-hive-udfs/pom.xml: Line 29: <dependency> > Is there a way to avoid this dependency? The problem with adding a static block is that we can't add it as a UDF from Hive. When Hive refers to the class for the first time, it throws the Error and the add function call fails. If we move it to inside the "evaluate", Catalog doesn't reach that point but UdfExecutor can handle it correctly. So we won't test the required code path. Any other way to workaround this? http://gerrit.cloudera.org:8080/#/c/3567/4/tests/test-hive-udfs/src/main/java/com/cloudera/impala/UnresolvedUdf.java File tests/test-hive-udfs/src/main/java/com/cloudera/impala/UnresolvedUdf.java: Line 24: * This class intends to test a UDF that has some classes Catalog's > ... some classes that the Catalog's class loader ... Done Line 26: * Google's phone number library that won't be shaded with the UDF jar. Catalog > The Catalog ... Done -- To view, visit http://gerrit.cloudera.org:8080/3567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1109614f1617caa9bb27e8c151e902aae71a6b41 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
