Alex Behm has posted comments on this change. Change subject: IMPALA-3820: Handle linkage errors while loading Java UDFs in Catalog ......................................................................
Patch Set 2: I think it's fine to add a bad jar to the test resources. Alternatively, you could look into adding a new JAR in the impala/tests/test-hive-udfs project. Maybe make the UDF depend on an external library that gets resolved by maven, but that we don't copy to HDFS as well? Since the consequences of this bug are pretty severe, I think a small test is worth the effort. -- To view, visit http://gerrit.cloudera.org:8080/3567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1109614f1617caa9bb27e8c151e902aae71a6b41 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: No
