Henry Robinson has posted comments on this change. Change subject: IMPALA-2347: Reuse metastore client connections in Catalog ......................................................................
Patch Set 8: (5 comments) Looks pretty good. http://gerrit.cloudera.org:8080/#/c/3381/8/fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java File fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java: PS8, Line 31: RetryingMetaStoreClient what does it retry? Are operations idempotent under retry? PS8, Line 32: There is no size limit. Can you clarify this comment now? There is a size limit to the number of cached connections. PS8, Line 39: threadpool threadpool?? Line 54: private HiveMetaHookLoader dummyHookLoader = new HiveMetaHookLoader() { > make it final? and static? PS8, Line 98: exceed exceeds -- To view, visit http://gerrit.cloudera.org:8080/3381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I517c0e1efef2584cd8d34017b33574f2ad69bd52 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
