Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-2347: Reuse metastore client connections in Catalog ......................................................................
Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/3381/8/fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java File fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java: PS8, Line 31: RetryingMetaStoreClient > what does it retry? Are operations idempotent under retry? - The retries are on individual metadata ops implemented by IMetastoreClient interface (for ex: getDbs(), alterTable()...). More details at [1]. - I'm not sure if it is totally idempotent, say in edge cases like network issues, where the HMS has committed the transaction but the Client doesn't get the confirmation. I think it would still retry and see a different exception. But I think the Catalog code is designed to handle these cases well. Not sure if this answers your question, please let me know if you are looking for any specific details. [1] https://github.com/cloudera/hive/blob/cdh5-1.1.0_5.7.0/metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java#L90 PS8, Line 32: There is no size limit. > Can you clarify this comment now? There is a size limit to the number of ca Updated the comment. Not relevant anymore. PS8, Line 39: threadpool > threadpool?? Updated. Line 54: private HiveMetaHookLoader dummyHookLoader = new HiveMetaHookLoader() { > make it final? Done Line 54: private HiveMetaHookLoader dummyHookLoader = new HiveMetaHookLoader() { > and static? Done PS8, Line 98: exceed > exceeds Done -- To view, visit http://gerrit.cloudera.org:8080/3381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I517c0e1efef2584cd8d34017b33574f2ad69bd52 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
