Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3851

to look at the new patch set (#2).

Change subject: IMPALA-3873: Add QueryStateAccessor
......................................................................

IMPALA-3873: Add QueryStateAccessor

In-flight and completed queries are tracked by different data structures
in ImpalaServer. However, we often want to access both in the same way,
by reading various bits of query metadata that are common to both. This
would involve special-case logic depending on what state the query was
in.

This patch adds ImpalaServer::QueryStateAccessor which wraps either a
QueryExecState or a QueryStateRecord and provides a common struct-like
interface to both. This is mostly useful for the debug webpages that use
these accessors to generate JSON for the query tables etc.

Change-Id: Iec3dae66a81988c99cde1516ff511186e17dd8c0
---
M be/src/service/CMakeLists.txt
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
A be/src/service/query-state-accessor.cc
A be/src/service/query-state-accessor.h
6 files changed, 337 insertions(+), 138 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/3851/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec3dae66a81988c99cde1516ff511186e17dd8c0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>

Reply via email to