Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3873: Add QueryStateAccessor ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3851/1/be/src/service/query-state-accessor.h File be/src/service/query-state-accessor.h: Line 27: /// proxying common getters to different underlying data structures. is this supposed to be the end state, or is this class a stop-gap. why would we not consolidate those different data structures? ie, why do we have separate QueryStateRecord and QueryExecState - both of which should be renamed to something containing the string ClientRequest anyway. -- To view, visit http://gerrit.cloudera.org:8080/3851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3dae66a81988c99cde1516ff511186e17dd8c0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
