Henry Robinson has posted comments on this change. Change subject: IMPALA-3873: Add QueryStateAccessor ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3851/1/be/src/service/query-state-accessor.h File be/src/service/query-state-accessor.h: Line 27: /// proxying common getters to different underlying data structures. > is this supposed to be the end state, or is this class a stop-gap. why woul the record is the archived version of the query metadata. The exec state is its representation while currently running. In the latter, values may change. In the former, after construction, values are fixed. In the latter, for example, the runtime profile string is generated on demand. In the former, the string is stored in the class (because the information that could generate it has been cleaned up). This is why there are two separate implementations of roughly the same read-only interface. Renaming should probably happen when all the query-related classes are renamed. -- To view, visit http://gerrit.cloudera.org:8080/3851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3dae66a81988c99cde1516ff511186e17dd8c0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
