Michael Brown has posted comments on this change. Change subject: IMPALA-3969: stress test: add option to (en|dis)able codegen ......................................................................
Patch Set 1: (1 comment) Thanks for the comments, Tim. I'll ask some questions here and address your answers and other outstanding comments in patch set 3. http://gerrit.cloudera.org:8080/#/c/3887/1/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: Line 724: cursor.execute( > While we're at it, what do you think about adding runtime_filter_mode? A fe If we want additional query options, instead of a separate query option added to concurrent_select.py each time we need one, what are your thoughts on something like ./concurrent_select.py --common_query_options DISABLE_CODEGEN=false,option2=value2,... Pros: no maintenance for anything we need to SET experimentally for all queries Cons: it looks ugly and requires callers to perfectly format the option. Do you foresee yourself needing others besides these 2? Thanks. -- To view, visit http://gerrit.cloudera.org:8080/3887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iada041aace60c218a12178d8f1b9a68ff29de72e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
