David Knupp has posted comments on this change.

Change subject: IMPALA-3969: stress test: add option to set common query options
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3887/3/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:

PS3, Line 1367: Comma-delimited string of query options and values
> The nargs idea is simple enough. I have a patch where that works (it's a tw
The verbosity complaint is valid, but not so bad if we provided short options, 
e.g., -o as a viable alternative for --common-query-option. Hopefully setting 
nargs="*" (or whatever is valid) will work.


-- 
To view, visit http://gerrit.cloudera.org:8080/3887
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iada041aace60c218a12178d8f1b9a68ff29de72e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to