Michael Brown has posted comments on this change. Change subject: IMPALA-3969: stress test: add option to set common query options ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3887/3/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: PS3, Line 1367: Comma-delimited string of query options and values > I think argparse has a standard way of dealing with multiple command line a The nargs idea is simple enough. I have a patch where that works (it's a two-line change). I need to make sure that when a Jenkins parameter value has spaces in it, Jenkins properly quotes when exporting it to the environment. I think using an append action would increase verbosity in the cases someone calls this from the command line: he'd have to reuse the option over and over again, which can be tedious to do. I'll test on Jenkins next and see what it does. -- To view, visit http://gerrit.cloudera.org:8080/3887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iada041aace60c218a12178d8f1b9a68ff29de72e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
