Alex Behm has posted comments on this change. Change subject: IMPALA-3964: Remove erroneous DCHECK in Parquet scanner. ......................................................................
Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/3940/2//COMMIT_MSG Commit Message: Line 18: The Fix: Removed the erroneous DCHECK. Added logic to determine if any change the part about "Added logic" to state that we now also transfer the scratch batch memory to the output batch in this case. Line 20: Augmented the load_nested.py script to snappy compress each of the mention the following things: - the flat TPCH is also snappy compressed so we are not making them more consistent - the existing tests in test_nested_types.py that use complextypestbl still provide good coverage of the uncompressed Parquet http://gerrit.cloudera.org:8080/#/c/3940/2/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 564: // filters/conjuncts or transfer memory ownership. remove the "or transfer memory ownership" part since we do actually need to transfer -- To view, visit http://gerrit.cloudera.org:8080/3940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0955c85d18dfba4bd29a35ec95d0355da050607 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Christopher Channing <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
