Michael Ho has posted comments on this change. Change subject: IMPALA-3964: Fix crash when a count(*) is performed on a nested collection. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3940/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 574: dst_batch->tuple_data_pool()->AcquireData(scratch_batch_->mem_pool(), false); Sorry for the late review. If we are materializing a collection with empty tuples, do we actually need to transfer the memory pool of the scratch batch or can we free it at this point ? -- To view, visit http://gerrit.cloudera.org:8080/3940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0955c85d18dfba4bd29a35ec95d0355da050607 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Christopher Channing <cchann...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Christopher Channing <cchann...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
