Alex Behm has posted comments on this change. Change subject: IMPALA-3964: Fix crash when a count(*) is performed on a nested collection. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3940/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 574: dst_batch->tuple_data_pool()->AcquireData(scratch_batch_->mem_pool(), false); > Sorry for the late review. If we are materializing a collection with empty We don't need to transfer in that case. However, we do need to transfer in case we are using the legacy aggs/joins because in that case we will have allocated the scratch batch's tuple pointers from the scratch batch's mem pool (and we need to transfer those). Seemed cleaner not to special case these different cases. -- To view, visit http://gerrit.cloudera.org:8080/3940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0955c85d18dfba4bd29a35ec95d0355da050607 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Christopher Channing <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Christopher Channing <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
