Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3063: Separate join inversion from join ordering. ......................................................................
Patch Set 2: (4 comments) will look at logic changes in a bit... http://gerrit.cloudera.org:8080/#/c/3846/2//COMMIT_MSG Commit Message: Line 7: IMPALA-3063: Separate join inversion from join ordering. the changes in test output make it look like some plans also change (so this isn't purely a separation of functionality?). http://gerrit.cloudera.org:8080/#/c/3846/2/testdata/workloads/functional-planner/queries/PlannerTest/outer-joins.test File testdata/workloads/functional-planner/queries/PlannerTest/outer-joins.test: Line 814: | |--07:HASH JOIN [RIGHT OUTER JOIN] why is this cross product flipped? http://gerrit.cloudera.org:8080/#/c/3846/2/testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test File testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test: Line 1088: | hash predicates: l_suppkey = s_suppkey, l_partkey = ps_partkey we've seen meaningless changes like this before. i'm wondering whether we should simply sort predicate lists Line 1777: | hash predicates: p_partkey = ps_partkey is this the right thing to do, given selectivities? -- To view, visit http://gerrit.cloudera.org:8080/3846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If86db7753fc585bb4c69612745ec0103278888a4 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
