Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3063: Separate join inversion from join ordering. ......................................................................
Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3846/4/fe/src/main/java/com/cloudera/impala/planner/Planner.java File fe/src/main/java/com/cloudera/impala/planner/Planner.java: Line 405: // Re-compute tuple ids because the backend assumes that their order corresponds to > it's DCHECKed in blocking-join-node.cc L102 and following agreed, let's not fix this as part of this change. however, this assumption doesn't really make sense, and should be removed. leave at least one todo in a conspicuous place. computeTupleIds() seems like a nice abstraction on its own, but it was introduced in order to recompute tuple ids because of this hard-to-comprehend assumption in blocking join node. if you feel that's the only reason why you want computeTupleIds(), leave a todo to remove that as well. -- To view, visit http://gerrit.cloudera.org:8080/3846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If86db7753fc585bb4c69612745ec0103278888a4 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
