Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3063: Separate join inversion from join ordering. ......................................................................
Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/3846/4/fe/src/main/java/com/cloudera/impala/planner/Planner.java File fe/src/main/java/com/cloudera/impala/planner/Planner.java: Line 385: // This inversion is only valid for local plans because there is no backend but you are inverting *only* if !isLocalPlan Line 405: // Re-compute tuple ids because the backend assumes that their order corresponds to where is that assumed? http://gerrit.cloudera.org:8080/#/c/3846/4/testdata/workloads/functional-planner/queries/PlannerTest/joins.test File testdata/workloads/functional-planner/queries/PlannerTest/joins.test: Line 728: ---- PLAN is the changed plan warranted based on the cardinalities? http://gerrit.cloudera.org:8080/#/c/3846/4/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test: Line 2506: ---- PLAN are these changes warranted, based on the cardinalities? Line 5131: ---- PARALLELPLANS very strange, this is missing a distributed-plans section Line 5139: 34:HASH JOIN [INNER JOIN, PARTITIONED] is this justified? -- To view, visit http://gerrit.cloudera.org:8080/3846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If86db7753fc585bb4c69612745ec0103278888a4 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
