Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose ......................................................................
Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/3994/2/be/src/util/webserver.cc File be/src/util/webserver.cc: PS2, Line 223: sWildcardAddress(http_address_ > Can you use IsWildcardAddress(http_address_) ? Done PS2, Line 224: If GetHostname() returns an error, hostname will remain as > um? if GetHostname() returns an error, hostname will be undefined. I assign hostname in L222. So if GetHostname() returns an error, hostname will remain whatever value it was (which in this case is 0.0.0.0). Clarified the comment a bit. http://gerrit.cloudera.org:8080/#/c/3994/2/shell/impala_client.py File shell/impala_client.py: PS2, Line 238: esult > Just return result? Done http://gerrit.cloudera.org:8080/#/c/3994/2/shell/impala_shell.py File shell/impala_shell.py: PS2, Line 686: ult.version > why? Else it will print http://localhost:25000 vs http://127.0.0.1:25000 If you think that's fine, I can remove this line. Line 877: > long line Done PS2, Line 880: (time.strftime("%Y-%m-%d %H:%M:%S", time.localtime()), : self.webserver_address)) > does this print for 'use' statements as well? I still think that's a bit ve Yes it does. I forgot that we never used to print the time before. I've removed it. -- To view, visit http://gerrit.cloudera.org:8080/3994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d167b66f2dd8629e40a7094d21ea7ce6b43d23b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
