Henry Robinson has posted comments on this change. Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose ......................................................................
Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3994/5/shell/impala_shell.py File shell/impala_shell.py: PS5, Line 874: if print_web_link: : print_web_link = (self.webserver_address != ImpalaShell.UNKNOWN_WEBSERVER) bit less confusing to write this as: print_web_link = print_web_link and self.webserver_address != ImpalaShell.UNKNOWN_WEBSERVER or if that's too long: if self.webserver_address == ImpalaShell.UNKNOWN_WEBSERVER: print_web_link = False -- To view, visit http://gerrit.cloudera.org:8080/3994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d167b66f2dd8629e40a7094d21ea7ce6b43d23b Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
