Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose ......................................................................
Patch Set 4: (2 comments) Also, all the shell tests pass with these changes. http://gerrit.cloudera.org:8080/#/c/3994/2/be/src/util/webserver.cc File be/src/util/webserver.cc: PS2, Line 224: e).ok()) { > GetHostname() makes no guarantees about what happens to the argument in the Makes sense. Done. http://gerrit.cloudera.org:8080/#/c/3994/2/shell/impala_shell.py File shell/impala_shell.py: PS2, Line 686: ult.version > What's wrong with that? They're both the same address. I was under the impression that some shell environments wouldn't create an automatic hyperlink for an address with "localhost". But changed it in any case as it doesn't matter that much. -- To view, visit http://gerrit.cloudera.org:8080/3994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d167b66f2dd8629e40a7094d21ea7ce6b43d23b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
