Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3988: Only use first 96 bits of query id ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/4065/6/be/src/scheduling/simple-scheduler.cc File be/src/scheduling/simple-scheduler.cc: PS6, Line 505: int > Will there be a chance of overflow here ? Should we use int64_t instead ? there is no plausible scenario in which we'll ever have 1 billion fragment instances for a single query, let alone more than that. i'll adapt the interface. http://gerrit.cloudera.org:8080/#/c/4065/6/be/src/util/uid-util.h File be/src/util/uid-util.h: PS6, Line 75: int > Does this have the same overflow problem here ? this interface doesn't really make any sense, i'll rework it (and hardwire int32_t). -- To view, visit http://gerrit.cloudera.org:8080/4065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia56a03ed9a1d7e77c72b66a01cd48c5b6bf3624f Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
