Henry Robinson has posted comments on this change. Change subject: IMPALA-3988: Only use first 96 bits of query id ......................................................................
Patch Set 8: (5 comments) Looks fine, few small comments. http://gerrit.cloudera.org:8080/#/c/4065/8/be/src/scheduling/simple-scheduler.cc File be/src/scheduling/simple-scheduler.cc: PS8, Line 505: int instance_idx = num_fragment_instances + j; it would be clearer as: params.instance_ids.push_back( CreateInstanceId(schedule->query_id(), num_fragment_instances)); ++num_fragment_instances; // (or in the loop statement) That way it's more obvious that the set of fragment instances is 0 - num_fragment_instances after the loop. http://gerrit.cloudera.org:8080/#/c/4065/8/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS8, Line 857: uuid query_uuid = uuid_generator(); don't need the temporary? http://gerrit.cloudera.org:8080/#/c/4065/8/be/src/util/uid-util-test.cc File be/src/util/uid-util-test.cc: PS8, Line 37: EXPECT_EQ(qid.hi, query_id.hi); : EXPECT_EQ(qid.lo, query_id.lo); Why not: EXPECT_EQ(GetQueryId(instance_id), query_id) http://gerrit.cloudera.org:8080/#/c/4065/8/be/src/util/uid-util.h File be/src/util/uid-util.h: PS8, Line 51: const constexpr Line 55: memcpy(&result.hi, &uuid.data[0], 8); do we know that memcpy of 8 bytes generates the same asm as : result.hi = *(reinterpreret_cast<int64_t*>(&uuid.data[0])); ? -- To view, visit http://gerrit.cloudera.org:8080/4065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia56a03ed9a1d7e77c72b66a01cd48c5b6bf3624f Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
