Michael Ho has posted comments on this change. Change subject: IMPALA-3988: Only use first 96 bits of query id ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4065/7/be/src/util/uid-util.h File be/src/util/uid-util.h: PS7, Line 61: (1L << 32) - 1 IMHO, defining this as a constant like the previous patch seems to be better as it gives a semantic meaning to this value (e.g. instance_idx_mask). PS7, Line 66: -1 nit: missing space. -- To view, visit http://gerrit.cloudera.org:8080/4065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia56a03ed9a1d7e77c72b66a01cd48c5b6bf3624f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
