Dan Hecht has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner ......................................................................
Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/3774/10/be/src/exec/hdfs-avro-scanner.h File be/src/exec/hdfs-avro-scanner.h: PS10, Line 93: Codegen parsing records, writing tuples and evaluating predicates In light of the earlier comments indicating it's confusing that each scanner CodeGen implementation returns a different set of functionality, let's be more specific here like you were with parquet and say "Codegen DecodeAvroData()". Line 95: /// otherwise. why did the explanation of the status return value go away in this comment since patch 9? http://gerrit.cloudera.org:8080/#/c/3774/10/be/src/exec/hdfs-parquet-scanner.h File be/src/exec/hdfs-parquet-scanner.h: Line 334: /// 'process_scratch_batch_fn' if codegen was successful or NULL otherwise. same here about return status comment going missing. i think you reverted some part of the patch 9? http://gerrit.cloudera.org:8080/#/c/3774/10/be/src/exec/hdfs-sequence-scanner.h File be/src/exec/hdfs-sequence-scanner.h: PS10, Line 170: Codegen writing tuples and evaluating predicates. "Codegen WriteAlignedTuples()" or whatever Line 171: /// 'write_aligned_tuples_fn' if codegen was successful or NULL otherwise. return status comment was removed here too. http://gerrit.cloudera.org:8080/#/c/3774/10/be/src/exec/hdfs-text-scanner.h File be/src/exec/hdfs-text-scanner.h: Line 60: /// Codegen writing tuples and evaluating predicates. Stores the resulting function in Likewise for these say "Codegen WriteAlignedTuples()" or whatever it is actually doing. Line 61: /// 'write_aligned_tuples_fn' if codegen was successful or NULL otherwise. comment was removed here too -- To view, visit http://gerrit.cloudera.org:8080/3774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic327e437c7cd2b3f92cdb11c1e907bfee2d44ee8 Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
