Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner ......................................................................
Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/3774/10/be/src/exec/hdfs-avro-scanner.h File be/src/exec/hdfs-avro-scanner.h: PS10, Line 93: Codegen parsing records, writing tuples and evaluating predicates > In light of the earlier comments indicating it's confusing that each scanne Done http://gerrit.cloudera.org:8080/#/c/3774/10/be/src/exec/hdfs-sequence-scanner.h File be/src/exec/hdfs-sequence-scanner.h: PS10, Line 170: Codegen writing tuples and evaluating predicates. > "Codegen WriteAlignedTuples()" or whatever Done http://gerrit.cloudera.org:8080/#/c/3774/10/be/src/exec/hdfs-text-scanner.h File be/src/exec/hdfs-text-scanner.h: Line 60: /// Codegen writing tuples and evaluating predicates. Stores the resulting function in > Likewise for these say "Codegen WriteAlignedTuples()" or whatever it is act Done -- To view, visit http://gerrit.cloudera.org:8080/3774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic327e437c7cd2b3f92cdb11c1e907bfee2d44ee8 Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
