Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner ......................................................................
Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/3774/9/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 165: if (codegend_process_scratch_batch_fn_ == NULL) { > nit: i think we can do without this blank line to help more code fit on a s Done http://gerrit.cloudera.org:8080/#/c/3774/9/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 689: const char* format_name = _THdfsFileFormat_VALUES_TO_NAMES.find(format)->second; > what does this print when we hit the default case above? and in the case w Done -- To view, visit http://gerrit.cloudera.org:8080/3774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic327e437c7cd2b3f92cdb11c1e907bfee2d44ee8 Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
