Henry Robinson has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator ......................................................................
Patch Set 1: (1 comment) Added code to move, rather than copy, input filter to output, which prevents briefly having two copies of the same large filter. http://gerrit.cloudera.org:8080/#/c/4066/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS1, Line 1994: ++state->num_received; : DCHECK_LE(state->num_received, state->src_fragment_instance_idxs.size()); > This doesn't seem very necessary anymore. It seems redundant seeing that we Good catch, done. -- To view, visit http://gerrit.cloudera.org:8080/4066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
