Henry Robinson has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4066/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS2, Line 2035: rather than copy it and take double the memory : // cost > I'm okay with how it is now if there's no easy way to swap the memory** There's no easy way, unfortunately. I tried to write a method that would effectively move the filter data into a TBloomFilter, but that's only possible if the source data is a string, and it's not, it's a raw pointer. The memory for the aggregated filter is freed immediately after the copy, so I'm ok with the momentary spike as part of copying it around. Line 2039: TBloomFilter* filter = &(const_cast<TBloomFilter&>(params.bloom_filter)); > Good call. Maybe it's worth adding the following in L2038 too: Done, but added it on line 2046 - should be true after both branches. -- To view, visit http://gerrit.cloudera.org:8080/4066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
