Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator ......................................................................
Patch Set 4: There were a few bugs in the code which I changed. They were: - The filter_mem_tracker_->Release() wasn't happening in the right place. - The DiscardFilter() did not discard properly if it received an OOM or an always_true filter as the first filter it received. - The outgoing filter was not set to have always_true if it was sending out a dummy filter. - I also brought down the tests MEM_LIMIT to 200M as we use less memory thanks to Henry's latest changes. It seems to be fine for now and passed relevant tests locally. I'm running it through another private build to make sure (because I saw some very confusing crashes earlier which don't show up anymore, but I still can't account for them yet). -- To view, visit http://gerrit.cloudera.org:8080/4066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: No
