Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts ......................................................................
Patch Set 5: > Thanks for fixing this. Would "set -u" help in those cases, too? There are some settings that are nice as they allow catching errors (personally I always use set -e), but they should be added as soon as one starts writing a script. For already existing scripts it's almost impossible to add them without substantial changes and thorough testing of every execution path, since the code written without these strict settings is almost guaranteed to break if you turn these on afterwards. -- To view, visit http://gerrit.cloudera.org:8080/4078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7503794180dee99eeb979e67f34e3b2edade70fe Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Yonghyun Hwang <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: No
