Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts ......................................................................
Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4078/1/bin/clean.sh File bin/clean.sh: PS1, Line 49: $IMPALA_ALL_LOGS_DIRS > May be I misunderstood your comment but for all practical purposes, we don' impala-config.sh sets multiple log directories: # Directories where local cluster logs will go when running tests or loading data export IMPALA_LOGS_DIR=${IMPALA_HOME}/logs export IMPALA_CLUSTER_LOGS_DIR=${IMPALA_LOGS_DIR}/cluster export IMPALA_DATA_LOADING_LOGS_DIR=${IMPALA_LOGS_DIR}/data_loading export IMPALA_DATA_LOADING_SQL_DIR=${IMPALA_DATA_LOADING_LOGS_DIR}/sql export IMPALA_FE_TEST_LOGS_DIR=${IMPALA_LOGS_DIR}/fe_tests export IMPALA_FE_TEST_COVERAGE_DIR=${IMPALA_FE_TEST_LOGS_DIR}/coverage export IMPALA_BE_TEST_LOGS_DIR=${IMPALA_LOGS_DIR}/be_tests export IMPALA_EE_TEST_LOGS_DIR=${IMPALA_LOGS_DIR}/ee_tests export IMPALA_CUSTOM_CLUSTER_TEST_LOGS_DIR=${IMPALA_LOGS_DIR}/custom_cluster_tests # List of all Impala log dirs and create them. export IMPALA_ALL_LOGS_DIRS="${IMPALA_CLUSTER_LOGS_DIR} ${IMPALA_DATA_LOADING_LOGS_DIR} ${IMPALA_DATA_LOADING_SQL_DIR} ${IMPALA_EE_TEST_LOGS_DIR} ${IMPALA_FE_TEST_COVERAGE_DIR} ${IMPALA_BE_TEST_LOGS_DIR} ${IMPALA_EE_TEST_LOGS_DIR} ${IMPALA_CUSTOM_CLUSTER_TEST_LOGS_DIR}" mkdir -p $IMPALA_ALL_LOGS_DIRS http://gerrit.cloudera.org:8080/#/c/4078/3/bin/impala-config.sh File bin/impala-config.sh: PS3, Line 45: $IMPALA_HOME/toolchain > missing quote ? I intentionally didn't touch assignments, because quoting is not strictly needed there and I wanted to limit the scope of the change. There are many other assignments that I didn't touch for this reason, but I can update those as well if you would prefer it that way - after all, quoting everywhere is the best practice. http://gerrit.cloudera.org:8080/#/c/4078/3/bin/run-all-tests.sh File bin/run-all-tests.sh: PS3, Line 111: ${IMPALA_HOME}/testdata/bin/split-hbase.sh > missing quote ? Done PS3, Line 137: ${IMPALA_HOME}/bin/run-workload.py > missing quote ? Done PS3, Line 173: ${IMPALA_HOME}/bin/start-impala-cluster.py > missing quote ? Done PS3, Line 177: ${IMPALA_HOME}/bin/mvn-quiet.sh > missing quote ? Done -- To view, visit http://gerrit.cloudera.org:8080/4078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7503794180dee99eeb979e67f34e3b2edade70fe Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: Yes
