Michael Ho has posted comments on this change.

Change subject: IMPALA-4006: dangerous rm -rf statements in scripts
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4078/3/bin/impala-config.sh
File bin/impala-config.sh:

PS3, Line 45: $IMPALA_HOME/toolchain
> I intentionally didn't touch assignments, because quoting is not strictly n
I believe it'd be great to update them all the way. Thanks again for the clean 
up.


-- 
To view, visit http://gerrit.cloudera.org:8080/4078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7503794180dee99eeb979e67f34e3b2edade70fe
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zoltan Ivanfi <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Zoltan Ivanfi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to