Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs. ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4162/1/fe/src/main/java/com/cloudera/impala/planner/DistributedPlanner.java File fe/src/main/java/com/cloudera/impala/planner/DistributedPlanner.java: PS1, Line 201: equivSets(inputPartition.getPartitionExprs(), partitionExprs So the fact that we may have constants doesn't affect this operation, correct? Do we have a test case that triggers this path? PS1, Line 217: don nit: "Don't" This files doesn't seem to be consistent on how comments are written. PS1, Line 231: partitionHint == null || partitionHint oh this three-way logic... http://gerrit.cloudera.org:8080/#/c/4162/1/testdata/workloads/functional-planner/queries/PlannerTest/insert.test File testdata/workloads/functional-planner/queries/PlannerTest/insert.test: PS1, Line 533: 2009, 1 Can we also add a case with a constant expr? e.g. 2010-1 Line 543: ==== For completion, can you add the test case from IMPALA-3930? -- To view, visit http://gerrit.cloudera.org:8080/4162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1084d49c95b7d867eeac3297fd2016daff0ab687 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
