Alex Behm has posted comments on this change. Change subject: IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs. ......................................................................
Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/4162/1/fe/src/main/java/com/cloudera/impala/planner/DistributedPlanner.java File fe/src/main/java/com/cloudera/impala/planner/DistributedPlanner.java: Line 199: // do nothing if the input fragment is already appropriately partitioned > expand comment: what happens if partitionExprs contains constants (why do y changed the code back to the original order PS1, Line 201: equivSets(inputPartition.getPartitionExprs(), partitionExprs > So the fact that we may have constants doesn't affect this operation, corre I moved the removal of constant exprs back up like it was before. PS1, Line 217: don > nit: "Don't" This files doesn't seem to be consistent on how comments are w Done Line 231: Preconditions.checkState(partitionHint == null || partitionHint); > partitionHint doesn't describe the meaning. repartitionHint? Done PS1, Line 231: partitionHint == null || partitionHint > oh this three-way logic... Yup, seems necessary though since there are 3 values Line 232: if (partitionExprs.isEmpty()) { > can't you short-circuit this path and move it right below l206? are there o Reworked to move this code up. The other corner case is the noshuffle hint which is handled in L197. http://gerrit.cloudera.org:8080/#/c/4162/1/testdata/workloads/functional-planner/queries/PlannerTest/insert.test File testdata/workloads/functional-planner/queries/PlannerTest/insert.test: PS1, Line 533: 2009, 1 > Can we also add a case with a constant expr? e.g. 2010-1 Done Line 543: ==== > For completion, can you add the test case from IMPALA-3930? That doesn't seem useful to me. Is there a specific aspect of the original test that you find particularly useful? Only because it's "a" repro from the JIRA doesn't mean it's the one which gives us most coverage. -- To view, visit http://gerrit.cloudera.org:8080/4162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1084d49c95b7d867eeac3297fd2016daff0ab687 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
