Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs. ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4162/1/fe/src/main/java/com/cloudera/impala/planner/DistributedPlanner.java File fe/src/main/java/com/cloudera/impala/planner/DistributedPlanner.java: Line 199: // do nothing if the input fragment is already appropriately partitioned expand comment: what happens if partitionExprs contains constants (why do you need to take them into account?) Line 231: Preconditions.checkState(partitionHint == null || partitionHint); partitionHint doesn't describe the meaning. repartitionHint? Line 232: if (partitionExprs.isEmpty()) { can't you short-circuit this path and move it right below l206? are there other hint-related corner cases that need to be excluded by the if stmt in l209? -- To view, visit http://gerrit.cloudera.org:8080/4162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1084d49c95b7d867eeac3297fd2016daff0ab687 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
