anujphadke has posted comments on this change. Change subject: IMPALA-4020: Catalog update can fail due to database creation/deletion in hive ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4161/1/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java: PS1, Line 590: "Error updating authorization policy: ", e); > What will happen if the database is dropped sometime before L588 and L590? I moved it to a function. Not sure if add those many parameters to a function is a good idea if we plan to reuse it somewhere else. I have moved newDbCache.put(db.getName().toLowerCase(), db); to the end like we discussed. Line 601: > You might want to add a comment here on when we catch this exception. Done Line 602: // Build a new DB cache, populate it, and replace the existing cache in one > IMO, this should be a WARN of lesser, given the DB has probably been delete Done -- To view, visit http://gerrit.cloudera.org:8080/4161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic228efbcceb9ef6c165d0d9aeef7202581e3e46a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
