Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4020: Handle external conflicting changes to HMS gracefully ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4161/4/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java: Line 546: * appropriately handled. You should also mention that this function returns NULL if we can't invalidate the db. PS4, Line 549: db You may want to rename this to 'existingDb' or 'oldDb'. Also, can you comment what it means for this to be null? PS4, Line 621: Db oldDb = oldDbCache.get(dbName.toLowerCase()); : Pair<Db, List<TTableName>> invalidatedDb = invalidateDb(msClient, : dbName.toLowerCase(), oldDb); : if (invalidatedDb == null) continue; : newDbCache.put(dbName.toLowerCase(), invalidatedDb.first); dbName.toLowerCase() is called 3 times in 4 lines of code :) -- To view, visit http://gerrit.cloudera.org:8080/4161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic228efbcceb9ef6c165d0d9aeef7202581e3e46a Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
