Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4020: Catalog update can fail due to database creation/deletion in hive ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4161/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java: PS2, Line 542: invalidateDatabase You can make the function return a Pair<Db, List<TTableName> and avoid passing newDbCache and tblsToBackgroundLoad since these are output parameters. PS2, Line 608: try { You can actually push the try catch in that function and have it return null if an error occurred. -- To view, visit http://gerrit.cloudera.org:8080/4161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic228efbcceb9ef6c165d0d9aeef7202581e3e46a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
