Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4155/1/testdata/workloads/functional-query/queries/QueryTest/alter-table.test File testdata/workloads/functional-query/queries/QueryTest/alter-table.test: PS1, Line 263: create external table t_part (i int) partitioned by (j int, s string) : location '$FILESYSTEM_PREFIX/test-warehouse/$DATABASE.db/t_part_tmp'; : alter table t_part add partition (j=cast(2-1 as int), s='2012'); : alter table t_part add if not exists partition (j=1, s='2012'); : alter table t_part add if not exists partition (j=1, s='2012/withslash'); : alter table t_part add partition (j=1, s=substring('foo2013bar', 4, 8)); > If any of thee queries fail, the client throws a Beeswax exception which is Done http://gerrit.cloudera.org:8080/#/c/4155/1/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: Line 55: def test_sanity(self, vector): > I'm not sure our execute_query_expect_success even makes sense, at least fo Done. Tested by hand and I'm convinced. -- To view, visit http://gerrit.cloudera.org:8080/4155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf667dd5e960768879c019e2037cf48ad4e4241b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
