Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4155/2/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: PS2, Line 59: self.run_stmt_in_hive("create database hms_sanity_db") In testing this test, I identified a test flake: this test can't be successfully run twice in a row in a dev environment, because hms_sanity_db will exist after the test completes, and then fail here after that. You can reproduce the problem via the following, twice, from the tests/ directory: impala-py.test -k test_sanity metadata/test_hms_integration.py One suggestion is to "DROP DATABASE IF EXISTS ... CASCADE" before L59. -- To view, visit http://gerrit.cloudera.org:8080/4155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf667dd5e960768879c019e2037cf48ad4e4241b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
