Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4155/3/tests/conftest.py File tests/conftest.py: PS3, Line 284: return first_db_name I don't really like that we return a db name but more than one DB is created if num_dbs > 1, and that tests using the fixture then have to do some string concatenation to derive those DBs' names, and that .test files only know 1 database, and that they have to do the same string concatenation. However, that's a lot of other mess to fix for this patch, so I'm willing to live with that. The .test problem is particularly gross and doesn't have an immediately obvious solution. -- To view, visit http://gerrit.cloudera.org:8080/4155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf667dd5e960768879c019e2037cf48ad4e4241b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
